Fix bug with reverse mapping indices in reduce operation (#78).

Also update relevant tests
BiocPy · Apr 12, 2024 · 7d2105b · 7d2105b
1 parent d20ec60
commit 7d2105b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/genomicranges/GenomicRanges.py b/src/genomicranges/GenomicRanges.py
@@ -1545,7 +1545,7 @@ def reduce(
                     _rev_map = []
                     for j in res_ir._mcols.get_column("revmap"):
                         _rev_map.append([_oindices[x] for x in j])
-                    rev_map.extend(_rev_map[0] * len(res_ir))
+                    rev_map.extend(_rev_map)
 
         all_merged_ranges = ut.combine_sequences(*all_grp_ranges)
 

diff --git a/tests/test_gr_inter_range_methods.py b/tests/test_gr_inter_range_methods.py
@@ -71,7 +71,7 @@ def test_reduce_with_gapwidth_with_reverse_map():
     assert (out.start == np.array([101, 104, 102, 105, 103])).all()
     assert (out.width == np.array([11, 30, 21, 5, 25])).all()
     assert (out.strand == np.array([0, 1, -1, -1, 0])).all()
-    assert out.mcols.column("revmap") == [0, 3, 1, 4, 2]
+    assert out.mcols.column("revmap") == [[0], [3], [1], [4], [2]]
 
 
 def test_range():