change to functional style for getters and setters #55

jkanche · 2023-10-29T04:52:39Z

Resolves: #51

for more information, see https://pre-commit.ci

jkanche · 2023-10-31T02:27:00Z

now @LTLA should we do the property based access on the Factor class with the warnings?

LTLA · 2023-10-31T05:17:45Z

i suppose so, if you must

for more information, see https://pre-commit.ci

src/biocframe/Factor.py

jkanche added 4 commits October 28, 2023 21:51

change to functional style for getters and setters

31d280a

Merge branch 'master' into functional

0bb6fe0

continue with the rest of the functional changes

2c42be1

Merge branch 'master' into functional

b8d3f3d

jkanche marked this pull request as ready for review October 31, 2023 02:07

jkanche and others added 3 commits October 30, 2023 19:13

for backwards compatibility

009e274

[pre-commit.ci] auto fixes from pre-commit.com hooks

24cc684

for more information, see https://pre-commit.ci

missing return

250dbec

jkanche and others added 2 commits October 31, 2023 07:28

update docstrings, add props setters with warnings.

533ddf4

[pre-commit.ci] auto fixes from pre-commit.com hooks

061e97e

for more information, see https://pre-commit.ci

jkanche requested a review from LTLA October 31, 2023 14:33

jkanche and others added 2 commits October 31, 2023 07:51

update README

bc3f322

[pre-commit.ci] auto fixes from pre-commit.com hooks

4f69260

for more information, see https://pre-commit.ci

LTLA reviewed Oct 31, 2023

View reviewed changes

src/biocframe/Factor.py Outdated Show resolved Hide resolved

Update docstring

f839d57

jkanche merged commit aeae220 into master Oct 31, 2023
5 checks passed

jkanche deleted the functional branch October 31, 2023 15:39

Provide feedback