Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some more lang tags #756

Closed
wants to merge 5 commits into from
Closed

Some more lang tags #756

wants to merge 5 commits into from

Conversation

themerekat
Copy link
Collaborator

Add lang tags to checklist and one index file

Pull Request Checklist:

Pre-Approval

  • There is a description section in the pull request that details what the proposed changes do. It can be very brief if need be, but it ought to exist.
  • Features and backlog bugs should be merged into the Development branch, NOT master
  • All new text is preferably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages)
  • There are no linter errors
  • Symbiota coding standards have been followed

Post-Approval

  • It is the code author's responsibility to merge their own pull request after it has been approved
  • If this PR represents a merge into the Development branch, remember to use the squash & merge option
  • Don't forget to delete your feature branch upon merge. Ignore this step as required.

Thanks for contributing and keeping it clean!

@themerekat themerekat requested a review from egbot December 7, 2023 17:20
@themerekat
Copy link
Collaborator Author

Oops, this PR includes a bunch of changes that have already been merged from a now-deleted branch. I don't think that will affect anything, but only the last commit has not been reviewed yet.

@egbot
Copy link
Member

egbot commented Dec 8, 2023

Best way to resolve this issue is to first do pull request: BioKIC/Development => BioKIC/lang-tags-dec
That should automatically modify this pull request to only show the most recent changes you made.

Copy link
Member

@egbot egbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my note about first needing to pull Development => lang-tags-dec branch before finalizing this PR

@themerekat
Copy link
Collaborator Author

Best way to resolve this issue is to first do pull request: BioKIC/Development => BioKIC/lang-tags-dec That should automatically modify this pull request to only show the most recent changes you made.

So, I think I did this, but now it's still showing 84 files changed...how to proceed?

@themerekat themerekat closed this Dec 11, 2023
@themerekat themerekat deleted the lang-tags-dec branch December 11, 2023 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants