Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjustments to lang tag files, including adding translator #754

Merged
merged 3 commits into from
Dec 7, 2023

Conversation

themerekat
Copy link
Collaborator

@themerekat themerekat commented Dec 7, 2023

This PR includes some cleaning up of previously-created lang tag files, including consolidating some files. I've also added translator and translation date to the top of the Spanish files that Samanta translated.

Pull Request Checklist:

Pre-Approval

  • There is a description section in the pull request that details what the proposed changes do. It can be very brief if need be, but it ought to exist.
  • Features and backlog bugs should be merged into the Development branch, NOT master
  • All new text is preferably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages)
  • There are no linter errors
  • Symbiota coding standards have been followed

Post-Approval

  • It is the code author's responsibility to merge their own pull request after it has been approved
  • If this PR represents a merge into the Development branch, remember to use the squash & merge option
  • Don't forget to delete your feature branch upon merge. Ignore this step as required.

Thanks for contributing and keeping it clean!

@themerekat themerekat requested review from egbot and Atticus29 December 7, 2023 16:28
Copy link
Member

@egbot egbot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love that attribution is being applied

@themerekat themerekat merged commit 5f12f16 into Development Dec 7, 2023
@themerekat themerekat deleted the lang-file-adjust branch December 7, 2023 16:54
@themerekat themerekat removed the request for review from Atticus29 December 7, 2023 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants