Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

508 compliance for collections/specprocessor/salix/salixhandler.php #616

Merged

Conversation

NikitaSalikov
Copy link
Collaborator

Before Changes:

Screen Shot 2023-09-08 at 2 20 03 PM

After Changes:

Screen Shot 2023-09-08 at 2 19 46 PM

Changes Made:

  • added Doctype and lang attribute
  • added labels for radio buttons
  • fixed fieldset error
  • Internationalized text. Added lang files (en,es,fr) to lang/collections/specprocessor/salix/salixhandler.es.php

Pull Request Checklist:

  • Features and backlog bugs should be merged into the Development branch, NOT master
  • [N/A] Hotfixes should be merged into both the Development and master branches (at the same time).
  • All new text is preferrably internationalized (i.e., no end-user-visible text is hard-coded on the PHP pages)
  • There are no linter errors
  • New features have responsive design (i.e., look aesthetically pleasing both full screen and with small or mobile screens)
  • Symbiota coding standards have been followed
  • [N/A] If any files have been reformatted (e.g., by an autoformatter), the reformat is its own, separate commit in the PR
  • Comment which GitHub issue(s), if any does this PR address
  • It is the code author's responsibility to merge their own pull request after it has been approved
  • If this PR represents a merge into the Development branch, remember to use the squash & merge option
  • [N/A] If this PR represents a merge from the Development branch into the master branch, remember to use the merge option
  • [N/A] If the dev team has agreed that this PR represents the last PR going into the Development branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock the Development branch to prevent accidental merges while QA takes place

Thanks for contributing and keeping it clean!

@NikitaSalikov NikitaSalikov marked this pull request as ready for review September 8, 2023 21:25
Copy link
Collaborator

@Atticus29 Atticus29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TVP says:
Screen Shot 2023-09-12 at 2 49 08 PM
Everything else looks great!

Copy link
Collaborator

@Atticus29 Atticus29 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a few easy changed and now TVP is happy. LGTM. Thanks!

@NikitaSalikov NikitaSalikov merged commit 431e48a into Development Sep 18, 2023
@NikitaSalikov NikitaSalikov deleted the 508-collections-specprocessor-salix-salixhandler branch September 18, 2023 18:29
egbot pushed a commit that referenced this pull request Nov 13, 2024
Changed conditional to check in list
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants