-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve button spacing in specupload #1708
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we are trying to get away from inline styling. I suggest adding a class to those buttons and then styling the class in main.css
@GregoryPost , the styling is putting them in divs, not in-line with the buttons. Are you saying that we should just add blanket padding to all buttons? |
Looks like there already is a class that could serve this purpose: .bottom-breathing-room-rel Example: |
No, just updating those buttons with an appropriate css class selector. If you do this you should not need the new divs with inline styling. |
@themerekat, You can also use a smaller gap class: "bottom-breathing-room-rel-sm" which might look more aesthetic. |
Still not super sure I like it, because now the Start Upload button is a little askew of these buttons, but it works. |
Pull Request Checklist:
From this:

To this:

Fixes: #1707
Pre-Approval
Development
branch, NOTmaster
Post-Approval
Development
branch, remember to use the squash & merge optionDevelopment
branch into the master branch, remember to use the merge optionmaster
branch, a subsequent PR frommaster
intoDevelopment
should be made merge option (i.e., no squash).Development
branch before a tagged release (i.e., before an imminent merge into the master branch), make sure to notify the team and lock theDevelopment
branch to prevent accidental merges while QA takes place. Follow the release protocol here.Thanks for contributing and keeping it clean!