Skip to content

Commit

Permalink
Remove Vertical-align from reset.css closes #1498 (#1518)
Browse files Browse the repository at this point in the history
* Remove Vertical-align from reset.css closes #1498

# Issue #1498
# Summary
Causes undesirable before for things that don't have a default vertical
align like tables, will expand height for some tds if valign top is
used. Also I don't know why reseting the vertical alignment would be
needed

* adding back vertical align but making it top instead of baseline

* fix vertical aligntop for taxa main image

* change over remaing valign propties to styles instead
  • Loading branch information
MuchQuak authored Aug 12, 2024
1 parent 6aa3e55 commit 71c6373
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion css/symbiota/reset.css
Original file line number Diff line number Diff line change
Expand Up @@ -89,8 +89,8 @@ video {
border: 0;
font-size: 100%;
font: inherit;
vertical-align: baseline;
font-family: var(--body-font-family);
vertical-align: top;
}
/* HTML5 display-role reset for older browsers */
article,
Expand Down
6 changes: 3 additions & 3 deletions taxa/index.php
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@
?>
<table id="innertable">
<tr>
<td colspan="2" valign="bottom">
<td colspan="2" style="vertical-align: bottom">
<?php
if($isEditor){
?>
Expand Down Expand Up @@ -128,7 +128,7 @@
</td>
</tr>
<tr>
<td width="300" valign="top">
<td width="300" style="vertical-align=top">
<div id="family"><?php echo '<b>' . $LANG['FAMILY'] . ':</b> ' . $taxonManager->getTaxonFamily(); ?></div>
<?php
if($vernArr = $taxonManager->getVernaculars()){
Expand Down Expand Up @@ -273,7 +273,7 @@
</td>
</tr>
<tr>
<td width="300" valign="top">
<td width="300" style="vertical-align: top">
<?php
if($taxonRank > 140) echo '<div id="family"><b>' . $LANG['FAMILY'] . ':</b> ' . $taxonManager->getTaxonFamily() . '</div>';
if(!$taxonManager->echoImages(0,1,0)){
Expand Down

0 comments on commit 71c6373

Please sign in to comment.