Added Base58 support, with tests. #22
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
| for i in n | ||
| @test decode(Base58, encode(Base58, i)) == i | ||
| end | ||
| println("... [DONE]") |
There was a problem hiding this comment.
@vinctux, admittedly I'm not familiar with Base58....can you add a few tests as string literals that are independently verifiable? Right now, your tests are validating that encode/decode are inverses, but only implicitly that encode and decode return the expected values.
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
tests.jlwith printing comments._NOTE:_ May not completely suit for upstream, missing generalisation of functions (currently only
Int -> Stringand vice versa), limited functionality for intended use with all sorts of addresses, asInt64isn't big enough to handle all of decoded data. I intend to create an additional PR fixing this in the near future.