Make Rust type colors consistent with other languages #298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Binaryify
added a commit
that referenced
this pull request
Aug 8, 2019
Make Rust type colors consistent with other languages
Binaryify
added a commit
that referenced
this pull request
Aug 8, 2019
Make Rust type colors consistent with other languages
Binaryify
added a commit
that referenced
this pull request
Aug 8, 2019
Make Rust type colors consistent with other languages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #288 was merged, Rust types have been showing up in blue rather than in yellow. This isn't consistent with other languages - consider the following two code samples in Rust and TypeScript, which are effectively the same constructs, just with different keywords:
VS Code's Rust grammar uses the
entity.name.type.rustscope for types - I think simply removing this rule would make it fall back to the existing definition forentity.name.type. That said, I'm not hugely experienced with VS Code color schemes, so it's entirely possible that I've messed this up 😅