Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable semanticHighlighting in the One Dark Pro theme #386

Closed
aeschli opened this issue Apr 23, 2020 · 3 comments
Closed

Enable semanticHighlighting in the One Dark Pro theme #386

aeschli opened this issue Apr 23, 2020 · 3 comments

Comments

@aeschli
Copy link

aeschli commented Apr 23, 2020

Since 1.43, VSCode themes can take advantage of semantic highlighting.

Every theme controls whether semantic tokens are enabled. So far, only built-in themes have it enabled and I filed this issue to ask you to opt-in for the One Dark Pro theme as well.

Adoption is easy and there are new cool styling possibilities.

To turn on semantic highlighting for you theme, all you have to do is put
"semanticHighlighting": true
in the theme definition file.

There's a good chance that no further change to the theme is needed (thanks to a default mapping from semantic tokens to TextMate scopes (if not, I'd be interested to know, so I can improve the defaults further)).

But, more interestingly, themes can tune and go wild by defining new styling rules against the semantic tokens:

"semanticTokenColors": {
    "variable.readonly": "#ff0000", 
    "parameter": { "fontStyle": "underline" },
    "*.declaration:java": { "fontStyle": "bold" }
} 

Check out our Semantic Highlighting Wiki and the Semantic Highlighting Guide for more details and feel free to ping me in this issue if I can help.

Thanks a lot and looking forward to semantic highlighting in your theme.

@Binaryify
Copy link
Owner

thank for the suggestion,will adapt that after enough testing

@Binaryify
Copy link
Owner

Binaryify commented Apr 24, 2020

it do have some bad broken change, need some time to adapt that

@Binaryify
Copy link
Owner

already support semantic highlighting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants