Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal colours seem off #382

Closed
FredHappyface opened this issue Apr 8, 2020 · 7 comments
Closed

Terminal colours seem off #382

FredHappyface opened this issue Apr 8, 2020 · 7 comments

Comments

@FredHappyface
Copy link

FredHappyface commented Apr 8, 2020

This may be a largely personal thing (to me that is) but the terminal colours seem off compared to other one dark terminal themes such as the konsole theme

VsCode:

image
image

Konsole:

image
image

Would like to add what a great project this is 😄

@Binaryify
Copy link
Owner

I don't know how to reproduce it, could you provide some way?
image

@FredHappyface
Copy link
Author

Here is some code that produces the output below:

Powershell

Write-Output "$([char]27)[35mMagenta$([char]27)[00m|$([char]27)[95mBrightMagenta$([char]27)[00m" 

Bash

echo -e '\033[35mMagenta\033[00m|\033[95mBrightMagenta\033[00m'

And here is the actual output:
image

^ This is using the Base24 OneDark theme

@Binaryify
Copy link
Owner

Binaryify commented May 19, 2020

i see, will improve that

@Binaryify
Copy link
Owner

will use your terminal color config, I think you did a good job

@FredHappyface
Copy link
Author

FredHappyface commented May 19, 2020

Thank you. I'll drop a copy of the colours here

Order is red, yellow, green, cyan, blue, purple followed by bright

base08: "e05561"
base09: "d18f52"
base0B: "8cc265"
base0C: "42b3c2"
base0D: "4aa5f0"
base0E: "c162de"
base12: "ff616e"
base13: "f0a45d"
base14: "a5e075"
base15: "4cd1e0"
base16: "4dc4ff"
base17: "de73ff"

Hope this helps 😊

@Binaryify
Copy link
Owner

just publish a new version, you can check it later

@FredHappyface
Copy link
Author

That's great. Thank you! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants