Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selection text background color and occurrences highlight text background color are extremely undistinguishable #305

Closed
victorteokw opened this issue May 21, 2019 · 7 comments
Labels
WIP Work In Process

Comments

@victorteokw
Copy link

When editor.occurrencesHighlight turned on (this is turned on by default), it's very difficult to know where is selection and where is symbol highlighting.

@Binaryify
Copy link
Owner

could you provide some screenshots

@Dassderdie
Copy link

I noticed this too. This is esspacially irritating when dealing with variables or strings and you want to copy a word in it.
Untouched:
untouched

editor.occurrencesHighlight = disabled
Cursor in string:
cursor-in-string
word selected:
word-selected

editor.occurrencesHighlight = enabled
Cursor in string:
cursor-in-string-occurences-enabled
word selected:
word-selected-occurences-enabled

@Binaryify Binaryify added the WIP Work In Process label Jun 29, 2019
@Binaryify
Copy link
Owner

I saw other themes have this issue too, thinking it's vscode itself issue, still don't know how to fix it

@Bandit
Copy link

Bandit commented Sep 11, 2019

I have this issue too - I just disabled editor.occurrencesHighlight for now 👍

@ghost
Copy link

ghost commented Oct 2, 2019

According to Theme Color Reference the color of the setting editor.wordHighlightBackground «must not be opaque so as not to hide underlying decorations». So I changed it from #484e5b to #d2e0ff2f and everything works fine.

Demo: before, after

@ghost
Copy link

ghost commented Oct 4, 2019

Same goes for the color of the setting editor.findMatchHighlightBackground. It must not be opaque:

Binaryify added a commit that referenced this issue Oct 6, 2019
@Binaryify
Copy link
Owner

just fixed this issues in v2.8.1
thank @exploreMax for his advice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work In Process
Projects
None yet
Development

No branches or pull requests

4 participants