serve cover art that is embedded into audio file #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgoltzsche
force-pushed
the
extract-coverart-from-item
branch
from
5d33bb8 to
1396c32
Compare
mgoltzsche
changed the title
mgoltzsche
force-pushed
the
extract-coverart-from-item
branch
from
1396c32 to
0234238
Compare
mgoltzsche
force-pushed
the
extract-coverart-from-item
branch
from
0234238 to
cc4715e
Compare
Make the `getCoverArt` endpoint extract and serve the coverart image from the audio file for items that don't specify an `album_id` or refer to an album that does not specify an `artpath`. Correspondingly, make the `getSong` endpoint return the song ID as `coverArt` ID when the song does not specify an `album_id`. Extracts the cover art into a temporary file using `ffmpeg` and lets flask serve it. Also, moves the `getCoverArt` endpoint implementation from `album.py` into a separate file since it is used to serve both album and single song cover art now.
mgoltzsche
force-pushed
the
extract-coverart-from-item
branch
from
cc4715e to
8a3b05f
Compare
|
Thanks a lot and sorry for the delay. I released v1.4.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
getCoverArtendpoint extract and serve the coverart image from the audio file for items that don't specify analbum_idor refer to an album that does not specify anartpath.Correspondingly, make the
getSongendpoint return the song ID ascoverArtID when the song does not specify analbum_id.Extracts the cover art into a temporary file using
ffmpegand lets flask serve it.Also, moves the
getCoverArtendpoint implementation fromalbum.pyinto a separate file since it is used to serve both album and single song cover art now.