list top artists/playlist, add mime types, fallback to default mime type #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aggregates the top artists per playlist and exposes them comma-separated within the `comment` field of each playlist. Also optimizes direct/single playlist access.
mgoltzsche
force-pushed
the
aggregate-playlist-artists
branch
from
7b346b5 to
42b4172
Compare
mgoltzsche
changed the title
mgoltzsche
changed the title
mgoltzsche
changed the title
mgoltzsche
changed the title
mgoltzsche
changed the title
mgoltzsche
force-pushed
the
aggregate-playlist-artists
branch
2 times, most recently
from
198fc08 to
f4f3196
Compare
mgoltzsche
changed the title
mgoltzsche
changed the title
mgoltzsche
force-pushed
the
aggregate-playlist-artists
branch
from
f4f3196 to
44edfb5
Compare
* Map .m4a, .mp4 and .opus file extensions to mime types. * Fallback to using mime type 'application/octet-stream' instead of failing the request when no mime type registered for file extension.
mgoltzsche
force-pushed
the
aggregate-playlist-artists
branch
from
44edfb5 to
1584586
Compare
mgoltzsche
changed the title
mgoltzsche
force-pushed
the
aggregate-playlist-artists
branch
3 times, most recently
from
7fdeca2 to
59e8003
Compare
Using the lower-case artist name without accents as key when grouping artists within a playlist.
mgoltzsche
force-pushed
the
aggregate-playlist-artists
branch
from
59e8003 to
6c5a89a
Compare
|
@BinaryBrain it would be great if you could review and merge this PR soon. Not having the mime type fix/enhancement prevents me from serving my music library using upstream Beetstream and I guess others have the same problem, e.g. see #11. |
|
Yes, I've been quite busy recently and the current version is broken if you don't have the smartplaylist plugin. |
|
ah, right, it fails here when neither the smartplaylist plugin was enabled nor the |
Don't fail but log a warning when the smartplaylist beets plugin is not enabled and the `playlist_dir` configuration option was not specified.
mgoltzsche
force-pushed
the
aggregate-playlist-artists
branch
from
d09d794 to
369b28a
Compare
|
Done: Now I've pushed another commit to not fail but log a warning when the smartplaylist plugin is not enabled and the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
commentfield of each playlist. Also optimizes direct/single playlist access.application/octet-stream(and log a warning) instead of failing the request. (At least GStreamer/Mopidy seems to do its own format detection anyway since it still plays such streams.)