Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: (DO-203) Fix is issue while passing args and command #8

Draft
wants to merge 16 commits into
base: main
Choose a base branch
from
Draft

fix: (DO-203) Fix is issue while passing args and command #8

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
8df5655
fix for passing args
Oct 2, 2024
3f3d63f
fix for passing args and command
Oct 2, 2024
3b8d972
feat(DO-203): Improve release pipeline for bls-chart)
Oct 15, 2024
af675ad
feat(DO-203): remove all node-modules
Oct 15, 2024
9299121
remove changelog
Oct 24, 2024
4cd3646
updated the release lifecycle
Oct 24, 2024
f1430e4
fix: updated the release lifecycle
Oct 24, 2024
61d7ec8
fix(DO-203): created the pipeline from scratch
Oct 24, 2024
e2954a1
fix(DO-203): kept args black
Oct 24, 2024
b700ae8
fix(DO-203): remove .releaserc no longer needed
Oct 24, 2024
c5d993b
fix(DO-203): remane the file
Oct 24, 2024
6b6b263
fix(DO-203): replace the coventional commit plugin with
Oct 24, 2024
7dba0cd
fix(DO-203): replace the coventional commit plugin with
Oct 24, 2024
9920174
fix(DO-203): remove space in value.yaml file
Oct 24, 2024
82a9f13
fix(DO-203): remove release.yaml
Oct 24, 2024
9df243c
fix(DO-203):run flow on push and pull request
Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions bls-chart/templates/deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,11 +33,11 @@ spec:
- name: {{ .Values.name }}
image: "{{ .Values.image.repository }}:{{ $imageTag }}"
imagePullPolicy: {{ .Values.image.imagePullPolicy }}
{{- if .Values.command }}
{{- if .Values.deployment.command }}
command:
{{- toYaml .Values.deployment.command | nindent 12 }}
{{- end }}
{{- if .Values.args }}
{{- if .Values.deployment.args }}
args:
{{- toYaml .Values.deployment.args | nindent 12 }}
{{- end }}
Expand Down
5 changes: 3 additions & 2 deletions bls-chart/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,8 +60,9 @@ deployment:
- /bin/sh
- -c
- echo Hello World
args: {}

args:
["start", "--optimized"]

livenessProbe:
path: /api/health
port: 8080
Expand Down
Loading