add sentry #84
Merged
add sentry #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
T-Damer
reviewed
Nov 17, 2023
src/helpers/handleError.ts
Outdated
| const message = parseError(e) | ||
| if (sendToSentry) { | ||
| if (e instanceof Error) { | ||
| console.log('catch') |
T-Damer
reviewed
Nov 17, 2023
| export function initSentry() { | ||
| Sentry.init({ | ||
| dsn: env.VITE_SENTRY_DSN, | ||
| environment: process.env.NODE_ENV, |
There was a problem hiding this comment.
I think we don't have it in vite/browser, make sure it logs dev/prod correctly
There was a problem hiding this comment.
T-Damer
reviewed
Nov 17, 2023
src/helpers/parseError.ts
Outdated
| } | ||
|
|
||
| export function stringifyError(e: unknown) { | ||
| if (typeof e === 'undefined') return e |
There was a problem hiding this comment.
Should return something else
There was a problem hiding this comment.
There was a problem hiding this comment.
If undefined we should provide some default text/error, I think
smyzin
reviewed
Nov 17, 2023
| @@ -19,5 +19,6 @@ export default cleanEnv(import.meta.env, { | |||
| VITE_KETL_INVITES_BACKEND: str({ | |||
| default: KETL_INVITES_BACKEND, | |||
| }), | |||
| VITE_SENTRY_DSN: str(), | |||
There was a problem hiding this comment.
Don't forget to update env file in the 1Pass
src/helpers/parseError.ts
Outdated
| } | ||
|
|
||
| export function stringifyError(e: unknown) { | ||
| if (typeof e === 'undefined') return e |
There was a problem hiding this comment.
If undefined we should provide some default text/error, I think
smyzin
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.