-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configuration simplification #202
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I successfully ported my app! The main side effect was needing to depend on quinn
and quinn-proto
, not just the latter.
What about re-exporting |
Cool, I missed that!
|
What is missing in |
9869ffe
to
f7e809c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still working for me! (you can revert re-exporting quinn-proto)
Thank you for reviewing this and feedback. Feel free to join the discord server so I can ping you some other time, for other reviews :P |
Amazing; didn't know that existed! |
This PR aims to simplify (and minimize)
wtransport
configurations (both server and client).In particular, it gives the possibility to configure a server and client directly passing the underlying transport configuration (i.e.,
quinn
). This follows the same approach adopted for the underlying TLS stack (i.e.rustls
).Some advanced methods are been removed, such as:
token_key
andenable_key_log
in the spirit of the mission ofwtransport
: having a minimal and user-friendly API. However, providing (with a single method) the configuration viaquinn
andrustls
all advanced configurations are still possible.This PR also changes
DnsResolver
interface: it simplifies the code and avoid usage of aMutex
for DNS resolution