Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow flexible cluster ids #205

Merged
merged 5 commits into from
Mar 20, 2023

Conversation

zoccoler
Copy link
Collaborator

This should fix #204

@zoccoler zoccoler marked this pull request as draft March 14, 2023 10:48
@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Merging #205 (00cc22a) into main (6e39600) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #205   +/-   ##
=======================================
  Coverage   77.03%   77.03%           
=======================================
  Files          14       14           
  Lines        1337     1337           
=======================================
  Hits         1030     1030           
  Misses        307      307           
Impacted Files Coverage Δ
napari_clusters_plotter/_plotter.py 50.21% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lazigu
Copy link
Collaborator

lazigu commented Mar 14, 2023

Marcelo @zoccoler, I think this should be marked as ready for review and merged. The problem with algorithmic clustering is related to plotting the 2D histogram in general, and not hiding not selected clusters, which is fixed by this PR.

@lazigu lazigu marked this pull request as ready for review March 16, 2023 12:11
@lazigu
Copy link
Collaborator

lazigu commented Mar 16, 2023

Accidentally marked this as ready for review.

It turns out, hiding non-selected clusters is not necessary for algorithmic clustering results, because that is already done by default, e.g. hdbscan detects noise points (non-selected grey points), which are not visualized:
image

Checking the "hide non-selected clusters" would hide in this case the first (orange) cluster:
image

I think for correctness we should rename the checkbox or add a tooltip, and leave it enabled only for manual clsutering results.

@lazigu
Copy link
Collaborator

lazigu commented Mar 20, 2023

I will merge this because it is needed to fix the issue of visualizing algorithmic clustering results in the 2D histogram plot, and deal with the issue described in my comment above in another PR.

@lazigu lazigu merged commit bac00d7 into main Mar 20, 2023
@lazigu lazigu deleted the fix_hide_non_selected_for_non_manual_clusters branch March 20, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hide non-selected only works for manual selections
2 participants