Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Rails 7.1 support #12

Merged

Conversation

argvniyx-enroute
Copy link
Contributor

@argvniyx-enroute argvniyx-enroute commented Apr 26, 2024

/task https://app.asana.com/0/1205835826533561/1205835897803472/f

@smudge @effron

This adds support for Rails 7.1:

  • Updates the Rails version range in the gemspec
  • Adds an Appraisals entry for 7.1
  • Bumps version.rb
  • bundle install and bundle exec appraisal to generate a new gemfile and update existing ones
  • Adds a Rails 7.1 entry to the gemfile matrix

@argvniyx-enroute argvniyx-enroute marked this pull request as ready for review April 26, 2024 15:52
Copy link
Contributor

@effron effron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM && platformLGTM

@argvniyx-enroute
Copy link
Contributor Author

@effron @samandmoore anyone with write powers mind merging this?

@effron
Copy link
Contributor

effron commented May 6, 2024

I don't have write access

@jacoblipson
Copy link

Hey @argvniyx-enroute! As we approach Rails 7.0 EOL, wanted to see if we can get this over the line! Do you just need someone with merge approvals to help get this out?

@argvniyx-enroute
Copy link
Contributor Author

Hey @argvniyx-enroute! As we approach Rails 7.0 EOL, wanted to see if we can get this over the line! Do you just need someone with merge approvals to help get this out?

That and apparently fixing a merge conflict woops (it's been that long)

@jacoblipson
Copy link

Haha yeah very fair! I think if we fixup the merge conflict I can help you get a repo maintainer to merge this!

@argvniyx-enroute
Copy link
Contributor Author

@jacoblipson alright I think that did it

Copy link

@jacoblipson jacoblipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM

Copy link

@jacoblipson jacoblipson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domainLGTM

@jacoblipson
Copy link

@smudge or @samandmoore looks like it's gotta be one of you two!

Copy link
Member

@smudge smudge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

domain LGTM && platform LGTM

@smudge smudge merged commit ca94ba2 into Betterment:main Nov 20, 2024
7 checks passed
@smudge
Copy link
Member

smudge commented Nov 20, 2024

Released!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants