-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Rails 7.1 support #12
Add Rails 7.1 support #12
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domainLGTM && platformLGTM
@effron @samandmoore anyone with write powers mind merging this? |
I don't have write access |
Hey @argvniyx-enroute! As we approach Rails 7.0 EOL, wanted to see if we can get this over the line! Do you just need someone with merge approvals to help get this out? |
That and apparently fixing a merge conflict woops (it's been that long) |
Haha yeah very fair! I think if we fixup the merge conflict I can help you get a repo maintainer to merge this! |
0225a59
to
e442dfc
Compare
@jacoblipson alright I think that did it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domainLGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domainLGTM
@smudge or @samandmoore looks like it's gotta be one of you two! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
domain LGTM && platform LGTM
Released! |
/task https://app.asana.com/0/1205835826533561/1205835897803472/f
@smudge @effron
This adds support for Rails 7.1:
Appraisals
entry for 7.1version.rb
bundle install
andbundle exec appraisal
to generate a new gemfile and update existing ones