-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: upgrade to flutter 3.13 #95
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #95 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 559 556 -3
=========================================
- Hits 559 556 -3
☔ View full report in Codecov by Sentry. |
Realised that a |
Probably another issue for this PR #97 |
Description
Upgrading to Flutter 3.13
Verticies
is now abase
annotated class indart:ui
so aFake
implementation is not possible anymore. However the test still passes when using a basic constructedVertices
ObjectMediaQuery
inFlutterGoldenTestWrapper
. There is already aMediaQuery
in the tree. This means that either the??
path of the Media Query was not hit during testing or the test would require adjustment as there are now 2MediaQuery
Widgets in the treeType of Change