Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: upgrade to flutter 3.13 #95

Merged
merged 6 commits into from
Sep 11, 2023
Merged

fix: upgrade to flutter 3.13 #95

merged 6 commits into from
Sep 11, 2023

Conversation

ABausG
Copy link
Contributor

@ABausG ABausG commented Aug 17, 2023

Description

Upgrading to Flutter 3.13

  • Increase Workflow's Flutter Version
  • Update Method Signature of TestWidgetsFn (Not 100% sure if this makes this a breaking change)
  • Verticies is now a base annotated class in dart:ui so a Fake implementation is not possible anymore. However the test still passes when using a basic constructed Vertices Object
  • Fix deprecation warnings
  • Update Goldens
  • Remove extra MediaQuery in FlutterGoldenTestWrapper. There is already a MediaQuery in the tree. This means that either the ?? path of the Media Query was not hit during testing or the test would require adjustment as there are now 2 MediaQuery Widgets in the tree

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (0a8b653) 100.00% compared to head (cc77e52) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #95   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          559       556    -3     
=========================================
- Hits           559       556    -3     
Files Changed Coverage Δ
lib/src/golden_test_adapter.dart 100.00% <100.00%> (ø)
lib/src/golden_test_runner.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ABausG ABausG requested a review from Kirpal August 22, 2023 06:53
@ABausG ABausG changed the title chore: upgrade to flutter 3.13 fix: upgrade to flutter 3.13 Aug 25, 2023
@ABausG
Copy link
Contributor Author

ABausG commented Aug 25, 2023

Realised that a fix tag is the more appropriate type of PR as it actually fixes the issue. Not 100% on the usage of the testWidgets outside of the package itself to determine if it actually is a breaking change

@karvulf
Copy link

karvulf commented Aug 30, 2023

Probably another issue for this PR #97

@Kirpal Kirpal merged commit b54138c into Betterment:main Sep 11, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants