Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dialog and dropdown are no longer visible on the golden files (#79) #91

Conversation

Brainyoo
Copy link
Contributor

@Brainyoo Brainyoo commented May 10, 2023

Description

Fixes #79

Currently, there is an issue where dialogues and dropdown menus are not being displayed correctly.

Cause

This error is caused by this commit.

Changes

In the golden_test_runner file, we have made an adjustment by reverting back to using the rootKey instead of the childKey. This fixes the problem and ensures that dialogues and dropdown menus are displayed correctly.

Test Scenarios

Additionally, we have created test scenarios for dialogues and dropdown menus to ensure proper functionality.

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (5117adc) 100.00% compared to head (e53fedd) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #91   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines          558       559    +1     
=========================================
+ Hits           558       559    +1     
Impacted Files Coverage Δ
lib/src/golden_test_adapter.dart 100.00% <100.00%> (ø)
lib/src/golden_test_runner.dart 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ladegeraet
Copy link

Would be nice if this fix could be merged... But I'm not sure why this pana task failes. @Betterment some ideas?

@btrautmann btrautmann merged commit 9153578 into Betterment:main May 25, 2023
@btrautmann
Copy link
Contributor

Thanks @Brainyoo. This has been released in 0.6.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: Dialog and dropdowns are no longer visible on the golden files
4 participants