Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to flutter 3.3.0 #75

Merged
merged 3 commits into from
Sep 7, 2022
Merged

chore: upgrade to flutter 3.3.0 #75

merged 3 commits into from
Sep 7, 2022

Conversation

Kirpal
Copy link
Collaborator

@Kirpal Kirpal commented Aug 31, 2022

Description

Upgrade to the latest flutter stable. Closes #74

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@@ -7,7 +7,7 @@ repository: https://github.com/Betterment/alchemist

environment:
sdk: ">=2.16.2 <3.0.0"
flutter: ">=3.0.0"
flutter: ">=3.3.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna tackle the dart upgrade as a separate effort?

Copy link
Contributor

@btrautmann btrautmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm once we upgrade CI to correct version

@codecov
Copy link

codecov bot commented Aug 31, 2022

Codecov Report

Merging #75 (12eaef1) into main (a80c62c) will decrease coverage by 0.36%.
The diff coverage is 75.00%.

@@             Coverage Diff             @@
##              main      #75      +/-   ##
===========================================
- Coverage   100.00%   99.63%   -0.37%     
===========================================
  Files           13       13              
  Lines          546      555       +9     
===========================================
+ Hits           546      553       +7     
- Misses           0        2       +2     
Impacted Files Coverage Δ
lib/src/host_platform.dart 91.66% <0.00%> (-8.34%) ⬇️
lib/src/blocked_text_image.dart 100.00% <100.00%> (ø)
lib/src/utilities.dart 100.00% <0.00%> (ø)
lib/src/golden_test.dart 100.00% <0.00%> (ø)
lib/src/golden_test_runner.dart 100.00% <0.00%> (ø)
lib/src/golden_test_adapter.dart 100.00% <0.00%> (ø)
lib/src/alchemist_test_variant.dart 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@renefloor
Copy link

Any update on this? Looks like it is finished and approved.

@Kirpal Kirpal merged commit 7722d48 into main Sep 7, 2022
@Kirpal Kirpal deleted the chore/flutter-upgrade branch September 7, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix: 'BlockedTextCanvasAdapter' is missing implementations for these members
3 participants