Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add improved example project #57

Merged
merged 4 commits into from
Jun 8, 2022

Conversation

jeroen-meijer
Copy link
Collaborator

Description

This PR adds an example project that showcases how to test a pair of example widgets.

The example.md file is preserved (with some minor change). This way, users on pub.dev will still see a single example file, but may also consult the full example project if they wish.

image

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@codecov
Copy link

codecov bot commented May 26, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@c55200c). Click here to learn what that means.
The diff coverage is n/a.

@@           Coverage Diff            @@
##             main       #57   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        12           
  Lines           ?       506           
  Branches        ?         0           
========================================
  Hits            ?       506           
  Misses          ?         0           
  Partials        ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c55200c...418a92c. Read the comment docs.

Copy link
Collaborator

@marcossevilla marcossevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a comment regarding changelog

@@ -1,3 +1,7 @@
# x.x.x

- feat: add improved example project
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we remove this changelog part? we can address that on #53

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Will do!

@Kirpal
Copy link
Collaborator

Kirpal commented May 26, 2022

This is all good, but it would be nice to see some more advanced use cases being tested, such as tapping, injecting app theme/localizations, loading images, etc. What do you think? I don't mind adding that if you'd like me to.

@alestiago
Copy link

@Kirpal maybe we can have more than one example, similar to how it's being done in the bloc library.

Thus, if one is not interested in learning about advanced use cases and only wants to know how to get started they can select a simpler example.

@jeroen-meijer
Copy link
Collaborator Author

jeroen-meijer commented May 27, 2022

Agreed with @Kirpal and @alestiago on this one.

I can rename this "simple_example" which allows us the opportunity to add more complex ones in the future. How does that sound?

PS: @Kirpal you can then add more examples in a separate PR if you'd like :)

@Kirpal
Copy link
Collaborator

Kirpal commented May 27, 2022

That sounds good to me! @jeroen-meijer @alestiago

@jeroen-meijer
Copy link
Collaborator Author

Will get to this tomorrow! :)

@marcossevilla
Copy link
Collaborator

@jeroen-meijer are we adding this simple example and then the complex one in a separate PR? just to see if we can approve/merge this one

@jeroen-meijer
Copy link
Collaborator Author

I guess we can do the rename later.

Sorry I haven't gotten to this yet, got swamped with other stuff :/
I say we merge this and do the more complex example and the rename later @marcossevilla 👍🏻

@marcossevilla
Copy link
Collaborator

I guess we can do the rename later.

Sorry I haven't gotten to this yet, got swamped with other stuff :/ I say we merge this and do the more complex example and the rename later @marcossevilla 👍🏻

no worries! lgtm 🚀

@marcossevilla marcossevilla merged commit d928855 into Betterment:main Jun 8, 2022
@jeroen-meijer jeroen-meijer deleted the feat/example-project branch June 10, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants