-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add improved example project #57
feat: add improved example project #57
Conversation
Codecov Report
@@ Coverage Diff @@
## main #57 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 12
Lines ? 506
Branches ? 0
========================================
Hits ? 506
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, just a comment regarding changelog
@@ -1,3 +1,7 @@ | |||
# x.x.x | |||
|
|||
- feat: add improved example project |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we remove this changelog part? we can address that on #53
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Will do!
This is all good, but it would be nice to see some more advanced use cases being tested, such as tapping, injecting app theme/localizations, loading images, etc. What do you think? I don't mind adding that if you'd like me to. |
@Kirpal maybe we can have more than one example, similar to how it's being done in the bloc library. Thus, if one is not interested in learning about advanced use cases and only wants to know how to get started they can select a simpler example. |
Agreed with @Kirpal and @alestiago on this one. I can rename this "simple_example" which allows us the opportunity to add more complex ones in the future. How does that sound? PS: @Kirpal you can then add more examples in a separate PR if you'd like :) |
That sounds good to me! @jeroen-meijer @alestiago |
Will get to this tomorrow! :) |
@jeroen-meijer are we adding this simple example and then the complex one in a separate PR? just to see if we can approve/merge this one |
I guess we can do the rename later. Sorry I haven't gotten to this yet, got swamped with other stuff :/ |
no worries! lgtm 🚀 |
Description
This PR adds an example project that showcases how to test a pair of example widgets.
The
example.md
file is preserved (with some minor change). This way, users on pub.dev will still see a single example file, but may also consult the full example project if they wish.Type of Change