chore: Additional cleanups #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolexxa
requested review from
samandmoore,
Kirpal and
jeroen-meijer
as code owners
LCOV of commit
|
Kirpal
approved these changes
Feb 16, 2022
LCOV of commit
|
samandmoore
reviewed
Feb 16, 2022
Comment on lines
+20
to
+32
| - name: Analyze project source | ||
| uses: invertase/github-action-dart-analyzer@v1 | ||
|
|
||
| - name: Run tests | ||
| run: flutter test --no-pub --coverage --test-randomize-ordering-seed random | ||
| run: flutter test --no-pub --coverage --test-randomize-ordering-seed=random | ||
|
|
||
| - name: Check Code Coverage | ||
| uses: VeryGoodOpenSource/very_good_coverage@v1.2.0 | ||
| - name: Report code coverage | ||
| uses: zgosalvez/github-actions-report-lcov@v1.4.0 | ||
| with: | ||
| path: coverage/lcov.info | ||
| coverage-files: coverage/lcov.info | ||
| minimum-coverage: 100 | ||
| github-token: ${{ secrets.GITHUB_TOKEN }} | ||
| artifact-name: code-coverage-report |
There was a problem hiding this comment.
looks like this diff is already on main?
samandmoore
reviewed
Feb 16, 2022
| @@ -0,0 +1,78 @@ | |||
| name: Bug Report | |||
There was a problem hiding this comment.
commenting here because i'm not sure where else to, i see we have some .yaml files and some .yml files. can we consolidate on one extension?
i'm fine with .yaml since that seems to be dart's preference. i'm used to .yml but it's really not a big deal haha
samandmoore
approved these changes
Feb 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Additional cleanups that @btrautmann called out