Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix!: load asset images for tests #25

Merged
merged 8 commits into from
Mar 10, 2022
Merged

fix!: load asset images for tests #25

merged 8 commits into from
Mar 10, 2022

Conversation

Kirpal
Copy link
Collaborator

@Kirpal Kirpal commented Mar 8, 2022

Description

Closes #16 .

I also made a (breaking) refactor to use a builder instead of a widget, which should prevent state from being unintentionally maintained between the ci and platform test runs. Also, what do we think about including precacheImages in this package?

Type of Change

  • ✨ New feature (non-breaking change which adds functionality)
  • 🛠️ Bug fix (non-breaking change which fixes an issue)
  • ❌ Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 Code refactor
  • ✅ Build configuration change
  • 📝 Documentation
  • 🗑️ Chore

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

LCOV of commit 2ec9f84 during alchemist #35

Summary coverage rate:
  lines......: 100.0% (454 of 454 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  lib/src/golden_test.dart           | 100%     35|    -     0|    -      0
  lib/src/golden_test_adapter.dart   | 100%     78|    -     0|    -      0
  lib/src/golden_test_runner.dart    | 100%     21|    -     0|    -      0

@github-actions
Copy link

github-actions bot commented Mar 8, 2022

LCOV of commit 4c43b97 during alchemist #36

Summary coverage rate:
  lines......: 98.3% (465 of 473 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  lib/src/golden_test.dart           | 100%     35|    -     0|    -      0
  lib/src/golden_test_adapter.dart   | 100%     78|    -     0|    -      0
  lib/src/golden_test_runner.dart    | 100%     21|    -     0|    -      0
  lib/src/pumps.dart                 |68.0%     25|    -     0|    -      0

⛔ The code coverage is too low. Expected at least 100.

lib/src/golden_test.dart Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

LCOV of commit 2c6cfce during alchemist #37

Summary coverage rate:
  lines......: 100.0% (473 of 473 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  lib/src/golden_test.dart           | 100%     35|    -     0|    -      0
  lib/src/golden_test_adapter.dart   | 100%     78|    -     0|    -      0
  lib/src/golden_test_runner.dart    | 100%     21|    -     0|    -      0
  lib/src/pumps.dart                 | 100%     25|    -     0|    -      0

@github-actions
Copy link

github-actions bot commented Mar 9, 2022

LCOV of commit 43ece00 during alchemist #38

Summary coverage rate:
  lines......: 100.0% (473 of 473 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate:
                                     |Lines       |Functions  |Branches    
  Filename                           |Rate     Num|Rate    Num|Rate     Num
  =========================================================================
  lib/src/golden_test.dart           | 100%     35|    -     0|    -      0
  lib/src/golden_test_adapter.dart   | 100%     78|    -     0|    -      0
  lib/src/golden_test_runner.dart    | 100%     21|    -     0|    -      0
  lib/src/pumps.dart                 | 100%     25|    -     0|    -      0

Copy link
Collaborator

@marcossevilla marcossevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is looking great! 🔥 had a couple of nit comments

test/src/pumps_test.dart Outdated Show resolved Hide resolved
test/src/pumps_test.dart Outdated Show resolved Hide resolved
test/src/pumps_test.dart Outdated Show resolved Hide resolved
test/src/pumps_test.dart Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 10, 2022

Codecov Report

❗ No coverage uploaded for pull request base (main@3db24f7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             main       #25   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        12           
  Lines           ?       483           
  Branches        ?         0           
========================================
  Hits            ?       483           
  Misses          ?         0           
  Partials        ?         0           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3db24f7...68dd1ec. Read the comment docs.

Copy link
Collaborator

@marcossevilla marcossevilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 💯

@Kirpal Kirpal merged commit 405788c into main Mar 10, 2022
@Kirpal Kirpal deleted the fix/asset-images branch March 10, 2022 20:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Assets image displayed for CI snapshot but not for platform
3 participants