-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix!: load asset images for tests #25
Conversation
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
LCOV of commit
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is looking great! 🔥 had a couple of nit comments
Codecov Report
@@ Coverage Diff @@
## main #25 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 12
Lines ? 483
Branches ? 0
========================================
Hits ? 483
Misses ? 0
Partials ? 0 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm 💯
Description
Closes #16 .
I also made a (breaking) refactor to use a
builder
instead of awidget
, which should prevent state from being unintentionally maintained between the ci and platform test runs. Also, what do we think about includingprecacheImages
in this package?Type of Change