fix: Could not override GoldenTestTheme #127
Conversation
Brainyoo
requested review from
samandmoore,
Kirpal,
jeroen-meijer,
btrautmann and
marcossevilla
as code owners
Brainyoo
changed the title
|
We use AlchemistConfig.runWithConfig() for our tests. The background colour is applied with the changes. But at the time when the TableBorder is to be coloured, Zone.current[currentConfigKey] is suddenly null, which is why our colour is not applied. |
| @@ -30,6 +30,7 @@ abstract class GoldenTestRunner { | |||
| required Widget widget, | |||
| required ThemeData? globalConfigTheme, | |||
| required ThemeData? variantConfigTheme, | |||
| required GoldenTestTheme? goldenTestTheme, | |||
There was a problem hiding this comment.
Interesting that I didn't get a lint warning me that I had added a parameter to an overridden method that wasn't present in the paren't method 🤔
|
@Brainyoo it looks like there are a couple tests that need to be updated for these changes! |
@Brainyoo am I correct in saying that this would still exist after your PR lands, i.e this PR does not address this bug? |
There was a problem hiding this comment.
Just wondering about the Theme Extension and whether we're expecting consumers to leverage that meaningfully or if we just want copyWith which we can hand roll as we have elsewhere. I don't see lerp being used meaningfully which made me wonder.
See next comment
|
@Brainyoo looks like just one failing test for |
|
Thank you @Brainyoo! |
Description
All our tests failed because the default GoldenTestTheme changed the background colour. The GoldenTestTheme cannot be overwritten as it is not exported via the barrel file.
Type of Change