feat: allow updating goldens on CI #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
btrautmann
requested review from
samandmoore,
Kirpal,
jeroen-meijer and
marcossevilla
as code owners
Kirpal
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of #118, we need to re-generate some goldens due to issues with Flutter 3.16 compatibility with existing goldens. See discussions on #103 and #104. However, generating these locally on MacOS to be used by CI does not re-generate all of them, indicating a difference between MacOS and Linux results (this is commented on here).
This PR adds a workflow that would allow maintainers to run a workflow to re-generate goldens on a given branch. The branch input is validated as part of the workflow.
RE: who has access to this button, see here. Basically, collaborators have access to this button, which I think is OK. We also ensure we're not updating
main, giving extra safety.You can see a successful run here which just so happened to run on my 3.16.0 PR and re-generate the correct goldens as shown here.
Type of Change