[LSP] Exclude repl output from lsp

[ericdallo]

What has Changed?

• Never send repl content to LSP analysis

Fixes #1250

My Calva PR Checklist

I have:

• Read How to Contribute.
• Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
• Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
• Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
• Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
• Added to or updated docs in this branch, if appropriate
• Tests
  • Tested the particular change
  • Figured if the change might have some side effects and tested those as well.
  • Smoke tested the extension as such.
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test.
• Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • If I am fixing the issue, I have used GitHub's fixes/closes syntax
  • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
• Created the issue I am fixing/addressing, if it was not present.

Ping @PEZ, @bpringe

[PEZ]

Thanks!

[PEZ]

There seems to be some unrelated commits in the PR branch. Can you clean that up? (I'm not sure this is necessary, but it is generally easier to deal with ”clean” PRs 😄.)

[PEZ]

@bpringe Are we relying on clojure-lsp in a way that we need to consider before merging this? I seem to recall something about the debugger using clojure-lsp analysis.

[ericdallo]

Thanks @PEZ ! Done, LMK if any more issues

[bpringe]

@PEZ The debugging code just uses clojure-lsp for decorations (for the instrumented functions). It doesn't seem to even add decorations in the repl window currently, and I'm unsure if that's intentional, but either way, I don't think it matters if this disallows that.

[bpringe]

Thanks @ericdallo! Let's merge. 🚀

[bpringe]

By the way, I removed that newline between changes in the unreleased section of the changelog (on dev). It might have caused an issue with our publish script.