Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linked editing range errors #1389

Merged
merged 1 commit into from
Nov 24, 2021

Conversation

ericdallo
Copy link
Contributor

@ericdallo ericdallo commented Nov 20, 2021

What has Changed?

  • Override provideLinkedEditingRange to disable the linkedEditingRange feature until we fix it properly as discussed on calva channel.

Fixes #1374

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
    • If I am fixing the issue, I have used GitHub's fixes/closes syntax
    • If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.
  • Created the issue I am fixing/addressing, if it was not present.

Ping @PEZ, @bpringe

@ericdallo ericdallo changed the title Fix linked editing range popups Fix linked editing range errors Nov 20, 2021
@bpringe
Copy link
Member

bpringe commented Nov 24, 2021

@ericdallo If you wouldn't mind updating the change log and doing the other appropriate steps in the PR checklist, I think we can merge this.

@ericdallo ericdallo force-pushed the fix-linked-editing-ranges branch from ae48b63 to d05a178 Compare November 24, 2021 02:28
@ericdallo
Copy link
Contributor Author

Done @bpringe, LMK if anything is missing

@ericdallo ericdallo force-pushed the fix-linked-editing-ranges branch from d05a178 to 45f8c8e Compare November 24, 2021 02:29
@bpringe bpringe merged commit c6c9037 into BetterThanTomorrow:dev Nov 24, 2021
@bpringe
Copy link
Member

bpringe commented Nov 24, 2021

Looks good to me. I did a quick test of the VSIX. Let's roll with it!

@ericdallo ericdallo deleted the fix-linked-editing-ranges branch November 24, 2021 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants