Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has Changed?
My Calva PR Checklist
I have:
dev
branch. (Or have specific reasons to target some other branch.)published
. (Sorry for the nagging.)[ ] Updated the[Unreleased]
entry inCHANGELOG.md
, linking the issue(s) that the PR is addressing.[ ] Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.[ ] Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on theci/circleci: build
test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.[ ] Tested the particular change[ ] Figured if the change might have some side effects and tested those as well.[ ] Smoke tested the extension as such.[ ] Referenced the issue I am fixing/addressing in a commit message for the pull request.[ ] If I am fixing the issue, I have used GitHub's fixes/closes syntax[ ] If I am fixing just part of the issue, I have just referenced it w/o any of the "fixes” keywords.[ ] Created the issue I am fixing/addressing, if it was not present.The Calva Team PR Checklist:
Before merging we (at least one of us) have:
dev
branch (unless reasons).Ping @PEZ, @bpringe