Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nrepl and clojure-lsp versions to Calva says greetings #1200

Merged
merged 4 commits into from
Jun 17, 2021

Conversation

PEZ
Copy link
Collaborator

@PEZ PEZ commented Jun 14, 2021

What has Changed?

We show configured jack in dependencies, and clojure-lsp versions in Calva says greetings message.

Fixes #1199

My Calva PR Checklist

I have:

  • Read How to Contribute.
  • Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
  • Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
  • Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
  • Added to or updated docs in this branch, if appropriate
  • Tested the VSIX built from the PR (so, after you've submitted the PR). You'll find the artifacts by clicking Show all checks in the CI section of the PR page, and then Details on the ci/circleci: build test. NB: You need to sign in/up at Circle CI to find the Artifacts tab.
    • Tested the particular change
    • Figured if the change might have some side effects and tested those as well.
    • Smoke tested the extension as such.
  • Referenced the issue I am fixing/addressing in a commit message for the pull request.
  • Created the issue I am fixing/addressing, if it was not present.

Ping @bpringe

@bpringe
Copy link
Member

bpringe commented Jun 14, 2021

Using the configuration to get the clojure-lsp version can be misleading if the user set a binary to be used with a custom path. https://calva.io/clojure-lsp/#using-a-custom-clojure-lsp-native-binary

The server info command is really the one source of truth for the clojure-lsp version. I do see you're saying "this is the version configured," so that would sort of be true, but not necessarily the version being used.

The same goes for nrepl. Depending on their classpath and tooling used (lein vs tools.deps), I think a different version of nrepl could be used than the one configured in jack-in deps. We'd also need to be aware of whether they connected to a repl without using jack-in, because in that case the nrepl version could be different too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants