chore(Burnex#check_domain_mx_record/1): Remove dns dependency in favo… #80
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r of erlang's :inet_res module
…ner_domain? return true
|
@Betree I took another look at this and have gotten the tests and dialyzer to pass. Can you take another look at it? |
Betree
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
@tomciopp Sorry for the very late review on this one; someone just pinged me about this, and I realized my Github notifications were not setup properly for this repo.
I've added a small commit to fix a Doctest in the README (gmail.fr is a valid domain).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…r of erlang's :inet_res module
@Betree This PR should simplify the code that double checks MX records. This gets rid of the dependency on the
dnsproject; of which the unmaintainedsocketlibrary is a sub dependency, in favor of using the built in erlang module. Let me know if you have any questions or need clarification.