Handle azure deepseek reasoning response #8288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| @@ -415,8 +416,17 @@ def convert_to_model_response_object( # noqa: PLR0915 | |||
| for field in choice["message"].keys(): | |||
| if field not in message_keys: | |||
| provider_specific_fields[field] = choice["message"][field] | |||
|
|
|||
| # Handle reasoning models that display `reasoning_content` within `content`` | |||
| content = choice["message"].get("content", None) | |||
There was a problem hiding this comment.
can we have this be in a separate helper function - it'll be easier to add a unit test for this as well
|
Thank you for the work on this @vibhavbhat - if you can just refactor the check to be in a separate helper function and add a direct test for that (prevents any future regression), i think we should be good! |
|
@krrishdholakia Added helper + unit tests |
|
@krrishdholakia is this good to merge? |
krrishdholakia
changed the base branch from
main
to
litellm_dev_02_07_2025_p1
krrishdholakia
merged commit dfb0266
into
BerriAI:litellm_dev_02_07_2025_p1
2 checks passed
krrishdholakia
added a commit
that referenced
this pull request
Feb 8, 2025
* Handle azure deepseek reasoning response (#8288) * Handle deepseek reasoning response * Add helper method + unit test * Fix: Follow infinity api url format (#8346) * Follow infinity api url format * Update test_infinity.py * fix(infinity/transformation.py): fix linting error --------- Co-authored-by: vibhavbhat <[email protected]> Co-authored-by: Hao Shan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Relevant issues
Fixes #8267
Type
🆕 New Feature
🐛 Bug Fix
✅ Test
Changes
Some deepseek model hosts (specifically Azure) returns the reasoning content within the content itself as
<think>Thinking Content<think>User facing response. This PR properly handles that case and puts the reasoning content on the api response as intended. This fix should work in general for all hosts that set the reasoning content like this.[REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes
Added test w/ reasoning content and it passed
Unit test for helper also passes
