-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(reasoning): compatible with the return data of the reasoning mod… #8286
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@krrishdholakia Do you think this PR needs to be merged? there aren't many customization scenarios for reasoning_content, and adding a global param doesn't seem necessary for now. |
Waiting for this one to be merged to have reasoning output in OpenRouter. Quite long... |
Hi @kuloud can you share a screenshot of this passing your test? Once done, it should be good to merge |
I found that I had some misunderstandings about the implementation within LiteLLM. I tried it and although Delta did handle the mapping of reasoning_content, I don't quite understand where in streaming_handler.py it is processed and the result is ignored.
When processing the reasoning information, it reaches
|
This PR doesn't solve the actual problem. It still requires your support @krrishdholakia |
I fixed the issue, and maybe I will make an new pr today or tomottow |
Title
compatible with the return data of the reasoning model
Relevant issues
Fixes #8193
Type
🐛 Bug Fix
Changes
[REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes