Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove recursive call #8225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

theGitNoob
Copy link
Contributor

@theGitNoob theGitNoob commented Feb 4, 2025

Title

Remove recursive call from together

Relevant issues

"Fixes #8223"

Type

🐛 Bug Fix

Changes

Added new method
This pull request removes unnecessary recursive call inside litellm.llms.together_ai.chat.TogetherAIConfig

Code Refactoring:

  • litellm/llms/together_ai/chat.py: Replaced the get_model_info import with get_model_param_support from litellm.utils and updated the get_supported_openai_params method to use this new utility function. [1]
  • litellm/utils.py: Added a new utility function get_model_param_support to retrieve model parameters .[1]

Data Updates:

[REQUIRED] Testing - Attach a screenshot of any new tests passing locally

If UI changes, send a screenshot/GIF of working UI fixes

Copy link

vercel bot commented Feb 4, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 0:08am

@theGitNoob theGitNoob force-pushed the fix/together_recursive_call branch from d2df5bf to 9db90b5 Compare February 4, 2025 00:08
@theGitNoob theGitNoob marked this pull request as ready for review February 4, 2025 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Unnecessary recursive call
1 participant