(Code QA Fixes) - Use LoggingCallbackManager to ensure no dup callbacks are added
#8070
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rect dict comparison
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| parent_list.append(callback) | ||
| else: | ||
| verbose_logger.debug( | ||
| f"Callback {callback} already exists in {parent_list}, not adding again.." |
Check failure
Code scanning / CodeQL
Clear-text logging of sensitive information High
Show autofix suggestion
Hide autofix suggestion
Copilot Autofix AI 6 days ago
To fix the problem, we should avoid logging sensitive information directly. Instead, we can log a generic message that does not include the sensitive data. This way, we maintain the logging functionality without exposing sensitive information.
- Replace the logging statement that includes the sensitive
callbackdata with a more generic message. - Specifically, change the logging statement in the
_add_string_callback_to_listmethod inlitellm/litellm_core_utils/logging_callback_manager.py.
Suggested changeset
1
litellm/litellm_core_utils/logging_callback_manager.py
| @@ -102,3 +102,3 @@ | ||
| verbose_logger.debug( | ||
| f"Callback {callback} already exists in {parent_list}, not adding again.." | ||
| "A callback already exists in the list, not adding again." | ||
| ) |
Copilot is powered by AI and may make mistakes. Always verify output.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(Code QA Fixes) - Use
LoggingCallbackManagerto ensure no dup callbacks are addedRelevant issues
Type
🆕 New Feature
🐛 Bug Fix
🧹 Refactoring
📖 Documentation
🚄 Infrastructure
✅ Test
Changes
[REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes