Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load vertex_credentials on every call #8068

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hakan458
Copy link

Title

Load Vertex credentials on every completion call (dont cache the access token library wide)

Relevant issues

Fixes #7904

Type

🐛 Bug Fix

Changes

In VertexLLM base, respect the vertex_credentials passed into a completion on every single call. Prior to this, access_token was being saved and any subsequent calls to a Vertex model with invalid credentials was still succeeding when it should not have. More info in the bug ticket above.

[REQUIRED] Testing - Attach a screenshot of any new tests passing locally

Was unable to run tests locally after doing a poetry install, some required packages are not included ...
e.g.

logging_callback_tests/test_langfuse_unit_tests.py:17: in <module>
    from respx import MockRouter
E   ModuleNotFoundError: No module named 'respx'
logging_callback_tests/test_amazing_s3_logs.py:16: in <module>
    import boto3
E   ModuleNotFoundError: No module named 'boto3'

And a couple others, opentelemetry , etc

Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2025 0:08am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Vertex Credentials Are Cached
1 participant