Retry for replicate completion response of status=processing #7901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use the DEFAULT_REPLICATE_ constants for retry count and initial delay. If the completion response returns status=processing, we loop to retry. Fixes BerriAI#7900 Signed-off-by: BJ Hargrave <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hi @bjhargrave can you share a screenshot of your change working as expected even better if you can add a unit test for it here - |
bjhargrave
added a commit
to ibm-granite-community/granite-snack-cookbook
that referenced
this pull request
Jan 23, 2025
Signed-off-by: BJ Hargrave <[email protected]>
|
With the current code, the PDL notebook fails when using replicate because the completion check encounters 
When using the fix in this PR by adding a pip install for the PR changes: The notebook completes successfully. https://github.com/ibm-granite-community/granite-snack-cookbook/actions/runs/12931609052/job/36065903001?pr=110#step:7:537 
|
krrishdholakia
changed the base branch from
main
to
litellm_dev_01_23_2025_p4
krrishdholakia
merged commit d98f132
into
BerriAI:litellm_dev_01_23_2025_p4
2 checks passed
krrishdholakia
added a commit
that referenced
this pull request
Jan 24, 2025
…7965) We use the DEFAULT_REPLICATE_ constants for retry count and initial delay. If the completion response returns status=processing, we loop to retry. Fixes #7900 Signed-off-by: BJ Hargrave <[email protected]> Co-authored-by: BJ Hargrave <[email protected]>
jarobey
pushed a commit
to jarobey/litellm
that referenced
this pull request
Jan 28, 2025
…#7901) (BerriAI#7965) We use the DEFAULT_REPLICATE_ constants for retry count and initial delay. If the completion response returns status=processing, we loop to retry. Fixes BerriAI#7900 Signed-off-by: BJ Hargrave <[email protected]> Co-authored-by: BJ Hargrave <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Retry for replicate completion response of status=processing
Relevant issues
Fixes #7900
Type
🐛 Bug Fix
Changes
We use the DEFAULT_REPLICATE_ constants for retry count and initial delay. If the completion response returns status=processing, we loop to retry.
[REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes
no new tests