(fix) GCS bucket logger - apply truncate_standard_logging_payload_content to standard_logging_payload and ensure GCS flushes queue on fails
#7500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ishaan-jaff
commented
Jan 2, 2025
| @@ -271,7 +267,6 @@ def create_datadog_logging_payload( | |||
| status = DataDogStatus.ERROR | |||
|
|
|||
| # Build the initial payload | |||
| truncate_standard_logging_payload_content(standard_logging_object) | |||
There was a problem hiding this comment.
moving this to be common logic for all logging integrations
rajatvig
pushed a commit
to rajatvig/litellm
that referenced
this pull request
Jan 16, 2025
…ntent` to `standard_logging_payload` and ensure GCS flushes queue on fails (BerriAI#7500) * use truncate_standard_logging_payload_content * update truncate_standard_logging_payload_content * update dd logger * update gcs async_send_batch * fix code check * test_datadog_payload_content_truncation * fix code quality
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(fix) GCS bucket logger - apply
truncate_standard_logging_payload_contenttostandard_logging_payloadand ensure GCS flushes queue on failsKey fixes:
truncate_standard_logging_payload_contentfor all logging integrations. Ensures no field instandard_logging_payloadis more than length10_000Relevant issues
Type
🐛 Bug Fix
✅ Test
Changes
[REQUIRED] Testing - Attach a screenshot of any new tests passing locally
If UI changes, send a screenshot/GIF of working UI fixes