Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed #6797 Fireworks AI structured outputs #6802

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

DaveDeCaprio
Copy link

Fix Fireworks AI Structured outputs

Relevant issues

Fixes #6797

Type

🐛 Bug Fix

Changes

Updated the fireworks_ai_transformation to use the format specified in the fireworks documentation: https://docs.fireworks.ai/structured-responses/structured-response-formatting

Copy link

vercel bot commented Nov 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
litellm ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 19, 2024 3:26pm

Copy link
Contributor

@ishaan-jaff ishaan-jaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • please add a unit test here: /test_fireworks_ai_translation.py
  • can you send a screenshot of a working request with your changes

@DaveDeCaprio
Copy link
Author

Here is a screenshot of logs showing the initial OpenAI response_format being converted to fireworks.ai and making a successful call.

image

@DaveDeCaprio
Copy link
Author

  • please add a unit test here: /test_fireworks_ai_translation.py
  • can you send a screenshot of a working request with your changes

Did a new commit that adds a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Error with StructuredOutputs and Fireworks.AI models
2 participants