fix: Add credential templates in migration job when using existing DB #6792
+14
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
stevencrake-nscale
force-pushed
the
fix/migration-db-useExisting
branch
from
29f83da to
3eb626e
Compare
stevencrake-nscale
force-pushed
the
fix/migration-db-useExisting
branch
from
8a00ceb to
3bf9003
Compare
stevencrake-nscale
changed the title
|
Related to #6985, since previous issue was closed, and I'd like to track this PR and fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title
Fix migration job failing for existing databases.
Relevant issues
Fixes #6791
Type
🐛 Bug Fix
Changes
If the chart is configured to use an existing database, the migration job will pull the necessary database credential information from secrets within the cluster. This follows the same pattern that the Deployment template currently uses.