Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not able to fix this JSON #31

Closed
andre-paulo98 opened this issue Jun 7, 2020 · 6 comments · Fixed by #32
Closed

Not able to fix this JSON #31

andre-paulo98 opened this issue Jun 7, 2020 · 6 comments · Fixed by #32
Labels
Priority: Medium released Type: Bug 🐛 Something isn't working

Comments

@andre-paulo98
Copy link

With this JSON as input: {something:"string:string"} it fails with this error: (enabled verbose) https://gist.github.com/andre-paulo98/746f77c4306f180b02f70c00ff474455

The website https://jsonformatter.curiousconcept.com/ is able to fix this JSON:
image

Environment

  • Version: 1.4.1
  • OS(s): Windows 10
  • Node version: 12.16.2
  • NPM version: 4.14.4
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label Type: Bug :bug: to this issue, with a confidence of 0.89. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

Berkmann18 added a commit that referenced this issue Jun 7, 2020
@Berkmann18
chore(samples): added the sample code from #31
0ffe7aa
Berkmann18 added a commit that referenced this issue Jun 7, 2020
@Berkmann18
fix(fixer): wrongly added missing quote
2ee5e4f 
Changed the missing-quote fixer to be more rigid

fix #31
@Berkmann18 Berkmann18 mentioned this issue Jun 7, 2020
Merged
11 tasks
@Berkmann18
Copy link
Owner

Thanks for opening the issue, and indeed the fixer wasn't able to fix such issues compared to other kinds of left-hand-side missing quotes issues.
I've added your example as a sample (which is used in the test suite) and so far it has been able to fix that issue while still being able to fix the others.

@Berkmann18
Copy link
Owner

@all-contributors Please add @andre-paulo98 for bug.

@allcontributors allcontributors bot mentioned this issue Jun 7, 2020
Merged
@allcontributors
Copy link
Contributor

@Berkmann18

I've put up a pull request to add @andre-paulo98! 🎉

github-actions bot pushed a commit that referenced this issue Jun 7, 2020
@semantic-release-bot
chore: release 1.4.2 🎉 [skip ci]
79cf19b 
## [1.4.2](v1.4.1...v1.4.2) (2020-06-07)

### Bug Fixes

* **fixer:** wrongly added missing quote ([2ee5e4f](2ee5e4f)), closes [#31](#31)
* **lockfile:** security fix ([cade206](cade206))
@github-actions
Copy link

github-actions bot commented Jun 7, 2020

🎉 This issue has been resolved in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

github-actions bot pushed a commit that referenced this issue Jun 7, 2020
@semantic-release-bot
chore: release 1.4.2 🎉 [skip ci]
f98b130 
## [1.4.2](v1.4.1...v1.4.2) (2020-06-07)

### Bug Fixes

* **fixer:** wrongly added missing quote ([2ee5e4f](2ee5e4f)), closes [#31](#31)
* **lockfile:** security fix ([cade206](cade206))
github-actions bot pushed a commit that referenced this issue Jun 8, 2020
@semantic-release-bot
chore: release 1.4.2 🎉 [skip ci]
36f61a4 
## [1.4.2](v1.4.1...v1.4.2) (2020-06-08)

### Bug Fixes

* security fix ([067bd46](067bd46))
* **fixer:** wrongly added missing quote ([2ee5e4f](2ee5e4f)), closes [#31](#31)
* **lockfile:** security fix ([cade206](cade206))
github-actions bot pushed a commit that referenced this issue Jun 8, 2020
@semantic-release-bot
chore: release 1.4.2 🎉 [skip ci]
72f7558 
## [1.4.2](v1.4.1...v1.4.2) (2020-06-08)

### Bug Fixes

* security fix ([067bd46](067bd46))
* **fixer:** wrongly added missing quote ([2ee5e4f](2ee5e4f)), closes [#31](#31)
* **lockfile:** security fix ([cade206](cade206))
github-actions bot pushed a commit that referenced this issue Jun 17, 2020
@semantic-release-bot
chore: release 1.4.2 🎉 [skip ci]
71f8c0a 
## [1.4.2](v1.4.1...v1.4.2) (2020-06-17)

### Bug Fixes

* missing quote fixer failure ([60a5fff](60a5fff))
* **fixer:** lint fix ([bbf3ed9](bbf3ed9))
* security fix ([067bd46](067bd46))
* **fixer:** wrongly added missing quote ([2ee5e4f](2ee5e4f)), closes [#31](#31)
* **lockfile:** security fix ([cade206](cade206))
github-actions bot pushed a commit that referenced this issue Jun 17, 2020
@semantic-release-bot
chore: release 1.4.2 🎉 [skip ci]
30580b2 
## [1.4.2](v1.4.1...v1.4.2) (2020-06-17)

### Bug Fixes

* missing quote fixer failure ([60a5fff](60a5fff))
* **fixer:** lint fix ([bbf3ed9](bbf3ed9))
* security fix ([067bd46](067bd46))
* **fixer:** wrongly added missing quote ([2ee5e4f](2ee5e4f)), closes [#31](#31)
* **lockfile:** security fix ([cade206](cade206))
github-actions bot pushed a commit that referenced this issue Jun 17, 2020
@semantic-release-bot
chore: release 1.4.2 🎉 [skip ci]
45e351f 
## [1.4.2](v1.4.1...v1.4.2) (2020-06-17)

### Bug Fixes

* missing quote fixer failure ([60a5fff](60a5fff))
* **fixer:** lint fix ([bbf3ed9](bbf3ed9))
* security fix ([067bd46](067bd46))
* **fixer:** wrongly added missing quote ([2ee5e4f](2ee5e4f)), closes [#31](#31)
* **lockfile:** security fix ([cade206](cade206))
github-actions bot pushed a commit that referenced this issue Jun 18, 2020
@semantic-release-bot
chore: release 1.4.2 🎉 [skip ci]
6af7cad 
## [1.4.2](v1.4.1...v1.4.2) (2020-06-18)

### Bug Fixes

* missing quote fixer failure ([60a5fff](60a5fff))
* **fixer:** lint fix ([bbf3ed9](bbf3ed9))
* security fix ([067bd46](067bd46))
* **fixer:** wrongly added missing quote ([2ee5e4f](2ee5e4f)), closes [#31](#31)
* **lockfile:** security fix ([cade206](cade206))
github-actions bot pushed a commit that referenced this issue Jun 27, 2020
@semantic-release-bot
chore: release 1.5.0 🎉 [skip ci]
030d027 
# [1.5.0](v1.4.1...v1.5.0) (2020-06-27)

### Bug Fixes

* **fixer:** fixing missing LHS quotes with 1-2 chars ([e2f8b9d](e2f8b9d))
* **fixer:** lint fix ([bbf3ed9](bbf3ed9))
* **fixer:** wrongly added missing quote ([2ee5e4f](2ee5e4f)), closes [#31](#31)
* **index:** not applying trailing-char fixes on LHS issues ([253ebfc](253ebfc)), closes [#38](#38)
* missing quote fixer failure ([60a5fff](60a5fff))
* security fix ([067bd46](067bd46))
* **lockfile:** security fix ([cade206](cade206))

### Features

* **fixer:** trailing char fixer simplification ([5899676](5899676))
@github-actions
Copy link

🎉 This issue has been resolved in version 1.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Medium released Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(fixer): revises the missing-quote fixer Berkmann18/json-fixer
2 participants
@Berkmann18 @andre-paulo98