Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.14.4 Generation Issues #22

Closed
robert-beckley opened this issue Jul 27, 2019 · 11 comments
Closed

1.14.4 Generation Issues #22

robert-beckley opened this issue Jul 27, 2019 · 11 comments
Assignees
Labels
bug Something isn't working

Comments

@robert-beckley
Copy link

Description
The generation does not work. And the clean super flat flag just turns is self off right way without doing anything.
The spawn chunks are fine but as soon as you go out from spawn its flat land.

Expected behaviour
The generator is set to bento box and new chunks are made in the grid format, not a flatland
world name is lowercase as bento box likes

Screenshots
image
image

Server Information:

[Please complete the following information:]

  • Database being used JSON
  • Java Version: 8
    image
    image

Additional context

configs.zip

Ping me on discord @robert#1017 for discussion

@tastybento tastybento added bug Something isn't working under investigation it's being checked out labels Jul 27, 2019
@tastybento tastybento self-assigned this Jul 27, 2019
tastybento added a commit to BentoBoxWorld/BentoBox that referenced this issue Jul 27, 2019
Will allow fix superflat to run in SkyGrid.

BentoBoxWorld/SkyGrid#22
@tastybento
Copy link
Member

Hi @robert-beckley - I'm not sure why you're getting the Superflat. I can't replicate that right now. However, I fixed the clean super turning off problem. I recommend you try the latest BentoBox and latest SkyGrid because there are significant fixes in both that you should pick up.

@robert-beckley
Copy link
Author

robert-beckley commented Jul 27, 2019 via email

@robert-beckley
Copy link
Author

Okay using these builds
image
everything seems a lot better. But when it makes the chunk it block updates and now everything is flowing lava/water
image
image

Will let it run for a while and see if anything odd happens but this is very good progress

@robert-beckley
Copy link
Author

robert-beckley commented Jul 28, 2019

Update: Chests are spawning empty in new chunks
image

@tastybento
Copy link
Member

Hi Robert,

Can you teleport somewhere way far away from the other chunks and see if the chunks spawn correctly for you? Ie there is no mention of chunk regeneration in the log? I’m concerned that we haven’t fixed the root cause which is that the chunks are not being generated from scratch correctly.
The fix Superflat is only supposed to be a worst case helper to fix when Superflat accidentally is generated for some reason and shouldn’t occur generally.
I’ll check into the chests and physics and see why that’s happening.

@tastybento
Copy link
Member

I had a look at your error log and you are getting warnings of large chunk sizes. These come from the server. I’m on my phone right now so I can’t check your confit. Did you change any config for SkyGrid like the height of the blocks?

tastybento added a commit to BentoBoxWorld/BentoBox that referenced this issue Jul 28, 2019
tastybento added a commit to BentoBoxWorld/BentoBox that referenced this issue Jul 28, 2019
@tastybento
Copy link
Member

Okay, I fixed the chests being empty and the water/lava flowing. That's in the latest BentoBox build.

I had a look at your config though and your height is 240 blocks - that will cause the "large chunk" errors you are seeing. I never knew this was an issue but chunks can only be up to a certain size normally. This used to be an exploit where someone could make a book with pages full of Chinese characters and put lots of them in chests and it would crash the server. Spigot and Paper "fixed" this by storing these super-sized chunks differently but maybe SkyGrid is crapping these out somehow and that's why you see the Superflat. I'd recommend reducing the block height to 128 and see if that's the root cause of the Superflat being generated.

@robert-beckley
Copy link
Author

Okay Update 1/2, Chests are now being generated with loot. The block updates are not happening. the only issue now is that the items are being dropped as it cycles through the blocks. This is something I can live with but it will make lag on many servers from all the entities. overall time per chunk regen is down also.
It still takes a few passes to get all the chunks even when loaded but how it is now is functioning well I am yet to check new "fresh" chunks and will let you know.
image
image

@robert-beckley
Copy link
Author

robert-beckley commented Jul 29, 2019

I don't think it is generating Fresh chunks it's more making a super flat then converting it fast I TPed far out (/tppos 10000000 65 10000000) and this is my result
image
I then turned off super flat cleaner and teleported to the negative of that location (/tppos -10000000 65 -10000000) and its all super flat

As for the large chunks yeah there is a duplication glitch with cramming the chest so the file size is too big and won't save. BUT I am getting that issue in sky block since updated and skyblock will not genera islands currently. (will be a new issue for that soon)
https://www.youtube.com/watch?v=sd8SM8YWP9U&t=2s

These are my current builds addon-version-buildnumer.jar
image

@tastybento
Copy link
Member

What version of Paper are you using?

tastybento added a commit to BentoBoxWorld/BentoBox that referenced this issue Jul 29, 2019
UseOwnGenerator is used by SkyGrid. This change makes sure MV
registration occurs.

BentoBoxWorld/SkyGrid#22
@tastybento tastybento removed the under investigation it's being checked out label Jul 29, 2019
@robert-beckley
Copy link
Author

robert-beckley commented Jul 29, 2019

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants