Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Negate permission #73

Closed
BoBsmil3Y opened this issue Mar 18, 2020 · 5 comments
Closed

Negate permission #73

BoBsmil3Y opened this issue Mar 18, 2020 · 5 comments
Assignees
Labels
bug Something isn't working

Comments

@BoBsmil3Y
Copy link

Description
Negate permission not working as expected. If you have one of those, it's unlock all of them. I have negate those : "bskyblock.island.limit.dispenser.110", "bskyblock.island.limit.dispenser.120", "bskyblock.island.limit.dispenser.130", and if I have the 110 perm, I unlock in the same time the 120, and the 130.

Steps to reproduce the behavior:

  1. Negate permissions in default rank
  2. Set you this rank
  3. Add you the perm (the lower one eg: 110)
  4. Relog
  5. Open is limits, and get all the perm negate.

Server Information:

  • OS: Debian
  • Java Version: 11

[10:22:04 INFO]: En cours d'exécution PAPER 1.15.1.
[10:22:04 INFO]: BentoBox version: 1.11.1
[10:22:04 INFO]: Database: MYSQL
[10:22:04 INFO]: Mondes de jeu chargés :
[10:22:04 INFO]: bskyblock_world (BSkyBlock): Overworld, [nether_color]Nether, [end_color]End
[10:22:04 INFO]: Addons chargés :
[10:22:04 INFO]: Biomes 1.6.0.1 (ENABLED)
[10:22:04 INFO]: BSkyBlock 1.11.0 (ENABLED)
[10:22:04 INFO]: Challenges 0.8.0 (ENABLED)
[10:22:04 INFO]: Level 1.9.3 (ENABLED)
[10:22:04 INFO]: Likes 1.7.0 (ENABLED)
[10:22:04 INFO]: Limits 1.9.2 (ENABLED)
[10:22:04 INFO]: MagicCobblestoneGenerator 1.7.0.2 (ENABLED)
[10:22:04 INFO]: Warps 1.9.0 (ENABLED)

@tastybento tastybento added bug Something isn't working under investigation this is being looked into labels Mar 18, 2020
@tastybento tastybento self-assigned this Mar 18, 2020
@tastybento tastybento removed the under investigation this is being looked into label Mar 18, 2020
@tastybento
Copy link
Member

Thanks. The new build on the CI should work for you. If not, let me know.

@BONNe
Copy link
Member

BONNe commented Mar 18, 2020

Tasty, why dont you use https://github.com/BentoBoxWorld/BentoBox/blob/develop/src/main/java/world/bentobox/bentobox/api/user/User.java#L295

And also, this should be fixed in User class too.

@tastybento
Copy link
Member

Yes. It should be used. I just fixed it in the User class.

@tastybento tastybento reopened this Mar 18, 2020
@tastybento
Copy link
Member

I remember now why I don't use the User class - it is because I do not know specifically which perms have been set. They are formatting so they change depending on the material or entity. So I have to cycle through all the effective perms anyway. By the time I do all the processing around those, there's nothing left to do that would require this User call.

So, this is fixed. Closing now.

@BONNe
Copy link
Member

BONNe commented Mar 19, 2020

Write a comment for that :)
Otherwise, I will ask you again after some months...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants