Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved CleanSuperFlat check #782

Merged
merged 3 commits into from
Jun 23, 2019
Merged

Improved CleanSuperFlat check #782

merged 3 commits into from
Jun 23, 2019

Conversation

YellowZaki
Copy link
Contributor

Today I found that BentoBox::Event: w.b.b.l.f.w.CleanSuperFlatListener (ChunkLoadEvent) was in the timings top and I didn't even have that flag enabled.
I went to the code and I found this...

@Poslovitch Poslovitch changed the base branch from master to develop June 23, 2019 05:00
@Poslovitch Poslovitch self-requested a review June 23, 2019 05:02
@Poslovitch Poslovitch added Status: Need review Waiting for a review to be made on this Pull Request Type: Bug labels Jun 23, 2019
@Poslovitch Poslovitch added this to the 1.6.0 milestone Jun 23, 2019
Poslovitch
Poslovitch requested changes Jun 23, 2019
View reviewed changes
Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This conflicts with an already existing check.

BentoBox/src/main/java/world/bentobox/bentobox/listeners/flags/worldsettings/CleanSuperFlatListener.java

Line 66 in 99d34d0

|| !Flags.CLEAN_SUPER_FLAT.isSetForWorld(world)

However, the "inWorld" check can be added. I'll do that, then merge the PR.

@Poslovitch Poslovitch added Status: Need revision Waiting for a revision to be made on this Pull Request and removed Status: Need review Waiting for a review to be made on this Pull Request labels Jun 23, 2019
@Poslovitch Poslovitch added Status: Done This issue has been completed or answered. This pull request has been merged. and removed Status: Need revision Waiting for a revision to be made on this Pull Request labels Jun 23, 2019
@Poslovitch Poslovitch changed the title Fixed CleanSuperFlat enabled check Improved CleanSuperFlat check Jun 23, 2019
@Poslovitch Poslovitch merged commit 2cf4909 into BentoBoxWorld:develop Jun 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Poslovitch Poslovitch Poslovitch approved these changes

Assignees
No one assigned
Labels
Status: Done This issue has been completed or answered. This pull request has been merged. Type: Bug
Projects
None yet
Milestone
1.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@YellowZaki @Poslovitch