Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto adds default placeholders for GameModeAddons #616

Merged
merged 3 commits into from
Mar 24, 2019

Conversation

tastybento
Copy link
Member

@tastybento tastybento requested a review from Poslovitch March 22, 2019 23:17
@Poslovitch Poslovitch added Type: Enhancement Improvement or modification which is usually a new feature. Priority: Medium Status: In progress Working on the issue. labels Mar 23, 2019
Copy link
Member

@Poslovitch Poslovitch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has been agreed on Discord that proceeding in the following manner should be investigated:

enum Placeholders {
    ISLAND_MEMBERS_COUNT("island-members-count", (island) -> island.getMembers().size());

    public Placeholders(String placeholder, Consumer placeholderReplacer) {...}

    public String getPlaceholder() {...}
    public Consumer getReplacer() {...}
}

@Poslovitch Poslovitch added this to the 1.4.0 milestone Mar 23, 2019
@tastybento tastybento self-assigned this Mar 23, 2019
@Poslovitch Poslovitch self-assigned this Mar 23, 2019
@Poslovitch
Copy link
Member

Okay, so... I couldn't come up with a better design, actually.
This PR has a very drafty feeling. But I'll merge it. We'll see how it goes.

@Poslovitch Poslovitch dismissed their stale review March 24, 2019 14:30

Couldn't come up with a better design

@Poslovitch Poslovitch added Status: Accepted and removed Status: In progress Working on the issue. labels Mar 24, 2019
@Poslovitch Poslovitch merged commit 2912ae1 into develop Mar 24, 2019
@Poslovitch Poslovitch deleted the default-placeholders branch April 4, 2019 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Improvement or modification which is usually a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants