2490 head getter memory leak #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heads must be gotten within 5 seconds otherwise the cache is cleared. Heads that have been retrieved will be kept in cache for 1 day
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents excessive cache expansion by using a new ExpiringMap that will automatically remove entries after a set period of time.
Addresses #2490
The root cause for the HashMap growth seen in #2490 is that the cache stores every panel that has ever made a request for a head and those entries are never deleted after the panel has been updated with the head (or not). The map continues to grow and store every panel ever for each head. This fixes the issue by giving an absolute max time for any cache - which is really what every cache should be using because otherwise the cache is relying on the server being rebooted.