Version 1.24.0 #2152
Merged
Version 1.24.0 #2152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new IslandNameEvent and test class for command
May break compatibility with older server versions.
Added 1.21.1
Made some admin commands have their own perm so that they can be controlled individually by permissions.
This makes it easier for listeners to determine if they should react or not.
Add API to enable gamemodes to register ownership over additional worlds
Bbox admin perms command
Update GitHub actions to NodeJS 16
Remove 1.20 from server compatibility as a result.
If sign is waxed (not editable) then no check is required
Protect against brushing
Adds calibrated sculk sensor to protection
Unregisters worlds with MV on shutdown.
tastybento
commented
Jun 30, 2023
|
|
||
| static | ||
| { | ||
| stringFlags = Map.of( |
There was a problem hiding this comment.
No need for this any more as Tag is used.
| /** | ||
| * Handle interaction with blocks | ||
| * | ||
| * @param e - event | ||
| */ | ||
| @EventHandler(priority = EventPriority.LOWEST, ignoreCancelled = true) | ||
| @EventHandler(priority = EventPriority.NORMAL, ignoreCancelled = true) |
There was a problem hiding this comment.
Changed priority to enable sign shops to be used. Previously it had no affect because we never checked signs, but now that we do, the priority needs to be higher. ChestShop uses LOW.
| @@ -65,13 +45,13 @@ public void onPlayerInteract(final PlayerInteractEvent e) | |||
| } | |||
|
|
|||
| // Check clicked block | |||
| this.checkClickedBlock(e, e.getPlayer(), e.getClickedBlock().getLocation(), e.getClickedBlock().getType()); | |||
| this.checkClickedBlock(e, e.getPlayer(), e.getClickedBlock()); | |||
There was a problem hiding this comment.
We need the block now, not just the type and location.
| // this.checkIsland(e, player, loc, Flags.CHEST); | ||
| // } | ||
|
|
||
| if (Tag.ITEMS_CHEST_BOATS.isTagged(type)) |
There was a problem hiding this comment.
Now use the tag. It's been available for a long time.
| @@ -124,7 +125,7 @@ public void onPlayerInteract(final PlayerInteractEvent e) | |||
| { | |||
| this.checkIsland(e, e.getPlayer(), e.getPlayer().getLocation(), Flags.PLACE_BLOCKS); | |||
| } | |||
| else if (e.getMaterial().name().contains("BOAT")) | |||
| else if (Tag.ITEMS_BOATS.isTagged(e.getMaterial())) | |||
There was a problem hiding this comment.
Use the tag instead of string check.
| || Tag.ITEMS_CHEST_BOATS.isTagged(ground) | ||
| || Tag.CAMPFIRES.isTagged(ground) | ||
| || Tag.FIRE.isTagged(ground) | ||
| || Tag.FIRE.isTagged(space1) | ||
| || space1.equals(Material.END_PORTAL) |
| player.updateInventory(); | ||
| } | ||
| } | ||
| readyPlayer(player); |
There was a problem hiding this comment.
Remove code duplication
| for (String line : fromSign.getLines()) { | ||
| toSign.setLine(i++, line); | ||
| for (Side side : Side.values()) { | ||
| writeSign(fromSign, toSign, side); |
| @@ -98,6 +101,15 @@ public void showAdminInfo(User user) { | |||
| if (island.getPurgeProtected()) { | |||
| user.sendMessage("commands.admin.info.purge-protected"); | |||
| } | |||
| // Fire info event to allow other addons to add to info | |||
| /** | ||
| * @since 1.24.0 | ||
| */ | ||
| V1_20(Compatibility.INCOMPATIBLE), |
There was a problem hiding this comment.
1.20 is not compatible because the waxed sign API is not in it, only in 1.20.1.
|
I think #2136 still needs to be done or looked at. |
This may help avoid mob shop clashes.
|
I think this is ready now. |
The goal is to make BentoBox less of a monster class and have fewer dependent classes.
Put island deletion under one class manager
BONNe
approved these changes
Jul 3, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Features and bug fixes and support for the latest Minecraft server version.