Implements NMS for pasting and supports older versions of server #2110
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds back in the use of NMS to paste blocks fast when pasting islands. It also implements the code required to support older versions of Minecraft properly with NMS. Right now, it supports 1.19.3 and 1.19.4 and if the server is not those versions then it falls back to Bukkit API. To support newer versions in the future is simple:
The reason why I only supported one version of the server via NMS in BentoBox (with ASkyBlock I had support for many, but it depended on local jar copies of the server) was because although Spigot provides a repo with the all the server versions, Maven only allows one version to be referenced. However, I found a workaround from StackExchange and this enables multiple versions to be dependencies. Therefore, the approach of selecting the correct class (or a fallback) can be used at last.