Add variable parsing on reference text #2073
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This solves the issue in customizable GUI's where variables are defined directly into the panel button name and description instead of providing the link to the locale. Not all users want to specify all text into a locale, and they would not get parsed variables just because of that. This change fixes it and it does not give any bad situations even if the reference is just missing text in the locale, as there will be nothing for parsing.
|
Kudos, SonarCloud Quality Gate passed! |
tastybento
approved these changes
Jan 24, 2023
|
I'm okay with merging this if you are @BONNe |
|
Yes, I am ok with it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves the issue in customizable GUI's where variables are defined directly into the panel button name and description instead of providing the link to the locale.
Not all users want to specify all text into a locale, and they would not get parsed variables just because of that. This change fixes it and it does not give any bad situations even if the reference is just missing text in the locale, as there will be nothing for parsing.